updated TODOs to reflect design decisions

This commit is contained in:
2018-09-02 17:05:32 +02:00
parent 5e00c46e2b
commit fee33d0c9b

View File

@@ -131,7 +131,6 @@ namespace RothenburgAR.Updater
public void TriggerUpdate()
{
// TODO create centralized network error feedback hub thing
/*
* dir structure:
* data
@@ -154,7 +153,7 @@ namespace RothenburgAR.Updater
UpdateConfirmationDialog.SetActive(false);
UpdateFailedDialog.SetActive(false);
//TODO write languages to file the app can read
//TODO write languages to file the app can read (so that the languagemanager can decide which languages the user can choose from)
var updatedMeta = VersionAnswer.data.Where(d => d.Meta.Status == VersionStatus.updated).ToList();
var updatedTracker = VersionAnswer.data.Where(d => d.Tracker.Status == VersionStatus.updated).ToList();
@@ -171,9 +170,16 @@ namespace RothenburgAR.Updater
updatedMeta.ForEach(d => UpdateMeta(d));
updatedTracker.ForEach(d => UpdateTracker(d));
var deletedMeta = VersionAnswer.data.Where(d => d.Meta.Status == VersionStatus.deleted).ToList();
var deletedTracker = VersionAnswer.data.Where(d => d.Tracker.Status == VersionStatus.deleted).ToList();
//TODO figure out if you can delete a tracker but not the meta (or vice versa)
var deletedData = VersionAnswer.data.Where(d =>
d.Meta.Status == VersionStatus.deleted
|| d.Tracker.Status == VersionStatus.deleted).ToList();
deletedData.ForEach(d => DeleteExhibition(d));
}
private void DeleteExhibition(ExhibitionVersion d)
{
//TODO implement DeleteExhibition
throw new NotImplementedException();
}
private void UpdateMeta(ExhibitionVersion exhibition)
@@ -250,7 +256,6 @@ namespace RothenburgAR.Updater
{
if (http.Request.isNetworkError || http.Request.isHttpError)
{
//TODO notify user about error (decide on level of detail)
Debug.LogError(String.Format("Error while downloading\nurl: {0}\nNetwork Error: {1}\nHttp Error: {2}\nHttp Response Code: {3}",
http.Request.url,
http.Request.isNetworkError,
@@ -260,6 +265,7 @@ namespace RothenburgAR.Updater
UpdateDialog.SetActive(true);
UpdateFailedDialog.SetActive(true);
//TODO decide on level of detail for user notification
//var all = UpdateFailedDialog.GetComponentsInChildren<TextMeshProUGUI>().ToList();
//var errorText = all.First(c => c.name == "ErrorText");
//errorText.text = string.Format("Fehlercode: {0}", http.Request.responseCode.ToString());
@@ -271,6 +277,7 @@ namespace RothenburgAR.Updater
private void UpdateTracker(ExhibitionVersion exhibition)
{
//TODO implement UpdateTracker
throw new NotImplementedException();
}